feat(ui): updates + dynamically sized window #16

Moosems · 2023-08-14T20:43:17Z

Need to still utilize the progressbar, update docs, and clean code more but this is a good start. Please: DO NOT TOUCH. @im-coder-lg, please comment that you've read this.

Closes #15

@im-coder-lg

Need to still utilize the progressbar, update docs, and clean code more but this is a good start. Please: DO NOT TOUCH. @im-coder-lg, please comment that you've read this.

Moosems · 2023-08-14T20:43:28Z

Again, NO TOUCHY!

Moosems · 2023-08-14T21:12:58Z

I would love it if eventually we used a web-scraper rather than using an API to make it scalable and free forever.

Moosems · 2023-08-14T21:19:55Z

Artifact build is not working for me but local source running is successful.

im-coder-lg · 2023-08-15T00:51:18Z

@Moosems I saw this, and as you said, I no touchy.

I would love it if eventually we used a web-scraper rather than using an API to make it scalable and free forever.

How about migrating to PyOWM? It seems to use the API but also format the data too, so we could perhaps migrate to that.

I'll keep my eye on this, and if you need any help, just ask.

im-coder-lg · 2023-08-15T00:59:26Z

Artifact build is not working for me but local source running is successful.

I'll test it on my computer as well as my cloud Gitpod instance.

@Moosems about the dynamic scaling, are you going to try to update the values after a search for the city is done? I did that on the dynamic-scaling branch, and it works well. I think this is the way most could go, but if you have another idea, can you delete the branch? We don't have a use for it anymore.

I'm updating the title, description and adding this to the repo project for tracking progress. Just slight changes.

not-nef · 2023-08-15T10:02:21Z

hello

sumeshir26 · 2023-08-15T10:04:50Z

hello

hi, good to see you back

not-nef · 2023-08-15T10:06:12Z

i kinda lost motivation for programming after that one bug in notes that i couldn’t fix

sumeshir26 · 2023-08-15T10:07:57Z

i kinda lost motivation for programming after that one bug in notes that i couldn’t fix

tkinter is frustrating sometimes. ive kinda moved on from tkinter programming at this point, and am learning newer things, so even i dont contribute much these days.

not-nef · 2023-08-15T10:09:09Z

i just think that tkinters simplicity is nice so i am kinda hanging onto it

Couldn't load before the results came in so effectively useless.

Moosems · 2023-08-15T12:19:58Z

Will make settings UI.

Moosems · 2023-08-15T12:50:26Z

Need to set up a simple file system, saving to it, and update the label info based on the systems.

@Moosems

Sorry @Moosems, I had to do it, now the artifacts could be fixed.

im-coder-lg · 2023-08-15T14:01:16Z

@Moosems I added sv_ttk to requirements file since it was missing, now you can use build artifacts directly I think.

im-coder-lg · 2023-08-15T14:06:51Z

Wait, I know there is an error with the artifact, I know the fix. 1 min!

This reverts commit 9d175d0.

This reverts commit 5c999bb.

im-coder-lg · 2023-08-15T15:13:21Z

I reverted my changes. @Moosems the artefacts don't recognise sv_ttk even after my changes. Can you look into it?

Moosems · 2023-08-15T15:21:54Z

@im-coder-lg Wait to touch the PR until I'm done please, still making some large changes ;).

Moosems · 2023-08-15T15:44:27Z

I'll get the artifacts fixed, don’t worry.

Moosems · 2023-08-15T15:56:38Z

Mac builds run fine from artifacts but now Linux is acting up.

im-coder-lg · 2023-08-15T16:39:59Z

Also, can you change the City label text's variables to the one I suggested? At least the name would be enough, so it auto-corrects the city name after receiving it.

What?

	    cityname = data["name"] + ", " + data["sys"]["country"]
        # Set the city name
        self.cityname.configure(text=f"City: {cityname}")

This. If you add this to main.py, the proper city name will be taken from the API.

@im-coder-lg Wait to touch the PR until I'm done please, still making some large changes ;).

Okay, but do it fast! Linux builds don't work due to the addition of Sun Valley.

I'll get the artifacts fixed, don’t worry.

Okay, but make sure the .spec files are proper.

Mac builds run fine from artifacts but now Linux is acting up.

Have you checked the .spec files? Maybe we must add sv_ttk as a hidden import(though it didn't work, but worth a try).

@im-coder-lg

@im-coder-lg Note that using different Springfield's (there's multiple cities named Springfield in the US) returns the same data. It makes no distinction between those in different states.

Moosems · 2023-08-15T20:47:42Z

You are clear to work on the Linux builds. Try to keep changes minimal if possible.

Moosems · 2023-08-15T20:50:08Z

Okay, but make sure the .spec files are proper.

I only added hooks. Would you open a discussion asking for thoughts on the PyInstaller repo?

im-coder-lg · 2023-08-16T14:02:24Z

Okay, but can't do today :( got too much of backlog to finish here. I still don't know how it accumulates. 🤔

Of course, I'll check with PyInstaller devs on this behaviour. I might have to mention this PR there, but we'll see. Add your changes and let's wait and watch.

Moosems · 2023-08-16T15:19:37Z

I'd give them the hook file, spec file, and then the traceback and leave it there, no need to link a big PR.

im-coder-lg · 2023-08-19T15:02:32Z

Posted a discussion over at PyInstaller: https://github.com/orgs/pyinstaller/discussions/7869

I linked the repo and the files, and only that, so this PR isn't linked but is accessible. I hope I get an answer to the issue soon.

Moosems · 2023-08-19T15:24:47Z

There was a response. @im-coder-lg could you have the Linux build use a newer Python version?

Moosems · 2023-08-19T15:25:53Z

3.9 or sooner.

Moosems · 2023-08-19T15:35:37Z

Or maybe a from __future__ import annotations would fix that.

im-coder-lg · 2023-08-19T15:45:33Z

We would have to rebase from main. I'll manage that mess, if you want me to. The workflow can be updated only on the main branch, so we gotta rebase, no questions asked.

im-coder-lg · 2023-08-19T15:52:04Z

Oh, fixed it with GitHub's UI. I thought we had to use Git :/

im-coder-lg · 2023-08-19T16:27:55Z

b2311101-24dd-4c14-9681-547f9782adc1.online-video-cutter.com.mp4

IT WORKS!!!!!

Finally, I pulled the recording off. Not so fancy as before, Clipchamp straight up reloaded to the login site over and over again.

Moosems · 2023-08-20T13:47:49Z

Ready to merge?

im-coder-lg

Approved! 👍

im-coder-lg · 2023-08-15T00:55:09Z

main.py

        self.cityname.grid(row=1, column=0, columnspan=2)

        self.searchbar = Entry(self.main_frame, width=42)
        self.searchbar.grid(row=2, column=0, columnspan=2, padx=10, pady=10)
+        self.bind("<Return>", self.OWMCITY)


It is good to notice this! I tried using the same bind() function, but it didn't work. Maybe because I had to use command= self.OWMCITY. I'll test this after lunch.

im-coder-lg · 2023-08-15T06:26:48Z

main.py

+
+        # Set the city name
+        self.cityname.configure(text=f"City: {city}")


Suggested change

# Set the city name

self.cityname.configure(text=f"City: {city}")

cityname = data["name"] + ", " + data["sys"]["country"]

# Set the city name

self.cityname.configure(text=f"City: {cityname}")

SUGGESTION

This change is simple: it takes the name of the city from the API(data["name") and adds it with the country code(data["sys"]["country"]). Now, even if a person enters a redundant name, it will change to the official name.

Would you please put it all in the f-string?

Well, isn't it already in a f-string? What are you referring to?

No need for a variable is what I mean.

Oh, now I get it. I'll fix it, I need some time. It's already nearing midnight and I'm doing homework. The Life of A Teenage Coder?

I will commit it, no problem.

If you do that, I will not work on it though.

I can improve the layout if you make a better one window idea though.

But then how can we integrate the settings into our main window?

It already is. It could use a better design, sure, but a whole window for two settings? That's a little over the top.

We could repurpose the same window for settings too. Any ideas on this type? We could use a tabbed window. I'll explain.

Basic work

5ecb774

Need to still utilize the progressbar, update docs, and clean code more but this is a good start. Please: DO NOT TOUCH. @im-coder-lg, please comment that you've read this.

Moosems added 2 commits August 14, 2023 17:16

More work

30e4f0f

Format

a51ea38

im-coder-lg assigned im-coder-lg and Moosems Aug 15, 2023

im-coder-lg changed the title ~~UI Updates~~ feat(ui): updates + dynamically sized window Aug 15, 2023

im-coder-lg added the enhancement New feature or request label Aug 15, 2023

Moosems added 2 commits August 15, 2023 08:18

Remove progressbar

ef949f0

Couldn't load before the results came in so effectively useless.

Remove test file

acd812b

Get new looks

1543cf5

Moosems and others added 2 commits August 15, 2023 09:08

Basic switching

ad145eb

fix(builderror): add to requirements.txt for build artifacts

9d175d0

Sorry @Moosems, I had to do it, now the artifacts could be fixed.

im-coder-lg added 3 commits August 15, 2023 14:28

fix(exe-error): add sv_ttk as hidden import

5c999bb

Revert "fix(builderror): add to requirements.txt for build artifacts"

d9644d7

This reverts commit 9d175d0.

Revert "fix(exe-error): add sv_ttk as hidden import"

5615a12

This reverts commit 5c999bb.

Format and add requirement

426ad4c

Fix local builds

795f5ab

Name fix

dfdb7ff

Moosems added 2 commits August 15, 2023 15:18

File writing

06ee8cf

Update name

aa10a9a

@im-coder-lg Note that using different Springfield's (there's multiple cities named Springfield in the US) returns the same data. It makes no distinction between those in different states.

Moosems added 3 commits August 16, 2023 07:53

Cleanup and small fix

f8d36d7

Better document and improve file writing

07a7651

Documentation

2d7ddad

Merge branch 'main' into ui-updates

c263ca0

im-coder-lg approved these changes Aug 20, 2023

View reviewed changes

im-coder-lg marked this pull request as ready for review August 20, 2023 17:38

Moosems merged commit 98247f7 into main Aug 20, 2023
3 checks passed

Moosems deleted the ui-updates branch August 20, 2023 19:09

im-coder-lg mentioned this pull request Aug 23, 2023

Settings Window #17

Closed


		# Set the city name
		self.cityname.configure(text=f"City: {city}")

feat(ui): updates + dynamically sized window #16

feat(ui): updates + dynamically sized window #16

Conversation

Moosems commented Aug 14, 2023 • edited by im-coder-lg Loading

Moosems commented Aug 14, 2023

Moosems commented Aug 14, 2023

Moosems commented Aug 14, 2023 • edited Loading

im-coder-lg commented Aug 15, 2023

im-coder-lg commented Aug 15, 2023

not-nef commented Aug 15, 2023

sumeshir26 commented Aug 15, 2023

not-nef commented Aug 15, 2023

sumeshir26 commented Aug 15, 2023

not-nef commented Aug 15, 2023

Moosems commented Aug 15, 2023

Moosems commented Aug 15, 2023

im-coder-lg commented Aug 15, 2023

im-coder-lg commented Aug 15, 2023

im-coder-lg commented Aug 15, 2023

Moosems commented Aug 15, 2023

Moosems commented Aug 15, 2023

Moosems commented Aug 15, 2023 • edited Loading

im-coder-lg commented Aug 15, 2023

Moosems commented Aug 15, 2023

Moosems commented Aug 15, 2023

im-coder-lg commented Aug 16, 2023

Moosems commented Aug 16, 2023

im-coder-lg commented Aug 19, 2023 • edited Loading

Moosems commented Aug 19, 2023

Moosems commented Aug 19, 2023

Moosems commented Aug 19, 2023

im-coder-lg commented Aug 19, 2023

im-coder-lg commented Aug 19, 2023

im-coder-lg commented Aug 19, 2023

Moosems commented Aug 20, 2023

im-coder-lg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SUGGESTION

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Moosems commented Aug 14, 2023 •

edited by im-coder-lg

Loading

Moosems commented Aug 14, 2023 •

edited

Loading

Moosems commented Aug 15, 2023 •

edited

Loading

im-coder-lg commented Aug 19, 2023 •

edited

Loading